Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move some utils to common, clean up #1068

Merged
merged 5 commits into from
Jun 23, 2023
Merged

refactor: move some utils to common, clean up #1068

merged 5 commits into from
Jun 23, 2023

Conversation

holic
Copy link
Member

@holic holic commented Jun 22, 2023 •
edited
Loading

  • Moves TableId and isDefined/isNotNull from utils to common
  • Defines return values of exported functions in common in enables linter for it

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b26f0f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic marked this pull request as ready for review June 22, 2023 16:54
@holic holic requested a review from alvrs as a code owner June 22, 2023 16:54
@holic holic changed the title refactor: move some utils to common refactor: move some utils to common, define common exports Jun 22, 2023
@holic holic changed the title refactor: move some utils to common, define common exports refactor: move some utils to common, specify common export return values Jun 22, 2023
@holic holic changed the title refactor: move some utils to common, specify common export return values refactor: move some utils to common, clean up Jun 22, 2023
holic
holic commented Jun 22, 2023
View reviewed changes
examples/minimal/packages/client-phaser/src/layers/network/contractComponents.ts
@@ -1,24 +0,0 @@
/* Autogenerated file. Do not edit manually. */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an unused file and was likely leftover from copy+pasting phaser things (the phaser template removed this file a while back)

@holic holic mentioned this pull request Jun 22, 2023
Merged
@holic
Copy link
Member Author

holic commented Jun 22, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@holic holic mentioned this pull request Jun 22, 2023
Merged
@holic holic mentioned this pull request Jun 22, 2023
Merged
alvrs
alvrs reviewed Jun 23, 2023
View reviewed changes
packages/common/src/TableId.ts
@@ -0,0 +1,37 @@
import { Hex, stringToHex, hexToString, sliceHex, concatHex } from "viem";

export class TableId {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename this to ResourceSelector? Or have a base class ResourceSelector this inherits from? (See #999 (comment))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh I like that better, will do

Copy link
Member Author

@holic holic Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, gonna save this for later! in searching the codebase for TableId, we have a lot of matches and so might wanna rethink the boundaries of this (i.e. when to use "resource selector" vs "table ID")

alvrs
alvrs approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment above is not blocking

@holic holic merged commit 17ea07b into main Jun 23, 2023
@holic holic deleted the holic/common-tableid branch June 23, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holic @alvrs