Fix magento2 driver #1420
Merged
Fix magento2 driver #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mischabraam Thanks so much for this PR! Because I have no experience with Magento, this is hard for me to review. Do you have any other members of the Magento community who could review this for us? |
|
Sure, no problem. |
|
I have been using the new version of the driver locally, and it works for me. It no longer just takes "production mode" for my local environment. |
|
@mischabraam I'm OK to merge this if you can manage the conflicts in this PR. Thank you! |
+ simplify, let mode determine by Magento env config
|
@mattstauffer The conflicts are resolved |
|
Thanks all. |
nickygerritsen
added a commit
to Lets-Talk-NL/valet
that referenced
this pull request
Dec 14, 2023
* upstream/master: (68 commits) Uses `actions/checkout@v4` Update CHANGELOG version Update CHANGELOG version Fix code styling Fix magento2 driver (laravel#1420) Update CHANGELOG version Fix code styling Fix code styling PHP 8.3 (laravel#1448) Update tests/CliTest.php Add conflict about mnapoli/silly 1.8.1–1.8.2 Bump requirement for mnapoli/silly to 1.5+ Add test of link command's isolate flag Ensure link command checks current directory for PHP version Improve link command's secure and isolate sub-commands Update CHANGELOG Fix code styling ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix magento2 driver + simplify, let mode determine by Magento env config
Fixes #1119 and #592