Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento2 Driver with pub as Doc root #592

Closed
davidverholen opened this issue Jun 1, 2018 · 1 comment
Closed

Magento2 Driver with pub as Doc root #592

davidverholen opened this issue Jun 1, 2018 · 1 comment

Comments

@davidverholen
Copy link

currently, Magento 2 does not seem to work in developer mode with the pub directory as Document Root (which is best practice and should be encouraged).

I tried valet today for the first time and it seems to be really great, but I had to change the magento 2 driver (or I was too stupid and missing something) to get it working with the pub directory as doc root.

For us not using the pub dir as doc root is not an alternative (and should not be forced for anyone tbh.)

So I'm just wondering if that maybe already is possible, and I'm just a valet noob, or if that is an issue that should be addressed.

Since it seems quite easy to implement a valet driver, I would also be willing to look into this if you think it makes sense, too.

In Addition to this, maybe some configuration to set the website / store view per valet project would be a nice feature if this can be added in the driver.

@driesvints
Copy link
Member

Hi there, we're cleaning up the Valet issue tracker and are moving all feature requests/support questions to the Discussions tab. We'll be using the issue tracker solely for bugs with Valet from now on. You're welcome to continue the discussion on in the Discussions tab. Thanks!

@laravel laravel locked and limited conversation to collaborators Dec 3, 2021
@driesvints driesvints converted this issue into discussion #1119 Dec 3, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants