Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Make IP to bind the server to configurable via env #607

Merged
merged 1 commit into from
Nov 2, 2022
Merged

[1.x] Make IP to bind the server to configurable via env #607

merged 1 commit into from
Nov 2, 2022

Conversation

xorinzor
Copy link
Contributor

@xorinzor xorinzor commented Nov 2, 2022

Building further on #605 this also makes the IP that the server listens on configurable using environment variables when no commandline argument for --host is provided.

The implementation should not break any existing deployments.

@xorinzor
Copy link
Contributor Author

xorinzor commented Nov 2, 2022

Ideally all of these arguments should be configurable via the octane config file. However I discovered quite quickly that this would break backwards compatibility with existing deployments unless they updated their config files.

Perhaps this is a breaking change worth considering for 2.0 and add it to a migration guide.
This PR maintains backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants