[1.x] Read port for http server from environment if no port is passed #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namoshek
reviewed
Oct 31, 2022
| @@ -16,7 +16,7 @@ class StartCommand extends Command implements SignalableCommandInterface | |||
| public $signature = 'octane:start | |||
| {--server= : The server that should be used to serve the application} | |||
| {--host=127.0.0.1 : The IP address the server should bind to} | |||
| {--port=8000 : The port the server should be available on} | |||
There was a problem hiding this comment.
@hendrikheil This change is safe but slightly inconvenient as it removes the default port from the --help text of the command:
// Before
--port[=PORT] The port the server should be available on [default: "8000"]
// After
--port[=PORT] The port the server should be available on
Might be worth to add this to the text 👍
There was a problem hiding this comment.
@Namoshek good suggestion. Added that: https://github.com/laravel/octane/blob/1.x/src/Commands/StartCommand.php
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add support for defining the HTTP server port through environment variables. The implementation shouldn't break any existing behavior.
This feature should be helpful for anyone that needs to run octane with a randomly generated port.