Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] add getRedisConnection to ThrottleRequestsWithRedis #47742

Merged
merged 3 commits into from
Jul 15, 2023
Merged

[10.x] add getRedisConnection to ThrottleRequestsWithRedis #47742

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcbc56e
add getRedisConnection
snmatsui Jul 14, 2023
077c450
comment: fix
snmatsui Jul 14, 2023
136f876
formatting
taylorotwell Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Illuminate/Routing/Middleware/ThrottleRequestsWithRedis.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ protected function handleRequest($request, Closure $next, array $limits)
protected function tooManyAttempts($key, $maxAttempts, $decayMinutes)
{
$limiter = new DurationLimiter(
$this->redis, $key, $maxAttempts, $decayMinutes * 60
$this->getRedisConnection(), $key, $maxAttempts, $decayMinutes * 60
);

return tap(! $limiter->acquire(), function () use ($key, $limiter) {
Expand Down Expand Up @@ -119,4 +119,14 @@ protected function getTimeUntilNextRetry($key)
{
return $this->decaysAt[$key] - $this->currentTime();
}

/**
* Get the Redis connection that should be used for throttling.
*
* @return \Illuminate\Redis\Connections\Connection
*/
protected function getRedisConnection()
{
return $this->redis->connection();
}
}