[10.x] add getRedisConnection to ThrottleRequestsWithRedis #47742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
\Illuminate\Contracts\Redis\Factory
usually become\Illuminate\Redis\RedisManager
by DI.DurationLimiter
constructor expects\Illuminate\Redis\Connections\Connection
, not\Illuminate\Contracts\Redis\Factory
.It now works because
\Illuminate\Redis\RedisManager
can behave as\Illuminate\Redis\Connections\Connection
by using default connection.Solution
Passing
\Illuminate\Redis\Connections\Connection
toDurationLimiter
is more prefer.Users who get benefits from this
Who wants to use Redis non-default connection for throttle count can override
getRedisConnection
method.