[10.x] Change ResetPassword::resetUrl() visibility to public static

[crynobone]

This provide solution for project using ResetPassword::toMailUsing() and ResetPassword::createMailUsing().

For example:

ResetPassword::createUrlUsing(function ($user, string $token) {
    return route('custom.password.reset', $token);
});

ResetPassword::toMailUsing(function ($notifiable, $token) {
    return (new MailMessage)
        ->subject(__('Reset Password Notification'))
        ->line(__('You are receiving this email because we received a password reset request for your account.'))
        ->action(__('Reset Password'), ResetPassword::resetUrl($notifiable, $token))
        ->line(__('If you did not request a password reset, no further action is required.'));
}); 

Signed-off-by: Mior Muhammad Zaki [email protected]

[taylorotwell]

I guess I don't totally follow why it is necessary? If ResetPassword::resetUrl is just going to call the route helper, why not just do that directly in toMailUsing?

ResetPassword::toMailUsing(function ($notifiable, $token) {
    return (new MailMessage)
        ->subject(__('Reset Password Notification'))
        ->line(__('You are receiving this email because we received a password reset request for your account.'))
        ->action(__('Reset Password'), route('custom.password.reset', $token))
        ->line(__('If you did not request a password reset, no further action is required.'));
}); 

[crynobone]

Yeah, but PR requesting access to the reset URL keep popping up from time to time:

• [8.x] Add the password reset URL to the toMailCallback #38552 merged and reverted
• [10.x] Update ResetPassword.php #41109 closed due to breaking change
• [9.x] handle toMailUsing and createUrlUsing for ResetPassword the same as in VerifyEmail #41514 closed due to breaking change

[taylorotwell]

I still just don't think this is super necessary. 🙃