[10.x] Update ResetPassword.php

[krusche-sensetence]

Setting
ResetPassword::createUrlUsing
was useless if also
ResetPassword::toMailUsing
was set.

The resetUrl wasn't calculated by the given ResetPassword::createUrlUsing callback and wasn't passed to the ResetPassword::toMailUsing callback.

[taylorotwell]

Why was sent to master? Is it breaking?

[driesvints]

@taylorotwell this will fail on 9.x after the test @crynobone sent in earlier today.

[taylorotwell]

#41104

Putting this here for reference.

[crynobone]

With these changes and app without password.reset, you will need to update the following code:

Before

ResetPassword::toMailUsing(function ($notifiable, $token) {
    return (new MailMessage)
        ->subject(__('Reset Password Notification'))
        ->line(__('You are receiving this email because we received a password reset request for your account.'))
        ->action(__('Reset Password'), route('custom.password.reset', $token))
        ->line(__('If you did not request a password reset, no further action is required.'));
});

After

ResetPassword::createUrlUsing(function ($user, string $token) {
    return route('custom.password.reset', $token);
});

ResetPassword::toMailUsing(function ($notifiable, $token, $resetUrl) {
    return (new MailMessage)
        ->subject(__('Reset Password Notification'))
        ->line(__('You are receiving this email because we received a password reset request for your account.'))
        ->action(__('Reset Password'), $resetUrl)
        ->line(__('If you did not request a password reset, no further action is required.'));
});

[krusche-sensetence]

@crynobone I adjusted the test

[taylorotwell]

I don't think I'm going to make this change. I think if you are using toMailUsing it is assumed you will create your own URL within that callback.