Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix CURRENT_TIMESTAMP as default when changing column #39377

Merged
merged 1 commit into from
Oct 28, 2021
Merged

[8.x] Fix CURRENT_TIMESTAMP as default when changing column #39377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Illuminate/Database/DBAL/TimestampType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@

use Doctrine\DBAL\DBALException;
use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Types\PhpDateTimeMappingType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this exist in the oldest version of doctrine that we support?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface was created in 2018 here: https://github.com/doctrine/dbal/commits/dca1465bdc0836c71ed97e46820490127ccc89ab/lib/Doctrine/DBAL/Types/PhpDateTimeMappingType.php

use Doctrine\DBAL\Types\Type;

class TimestampType extends Type
class TimestampType extends Type implements PhpDateTimeMappingType
{
/**
* {@inheritdoc}
Expand Down