[8.x] Fix CURRENT_TIMESTAMP as default when changing column #39377
Conversation
|
Is there any documentation within Doctrine on why we should do this or how it behaves? |
|
It appears that this is the only attached behaviour within Doctine. I couldn't find any documentation regarding it, maybe @TomHAnderson can provide some more insight here? |
| @@ -4,9 +4,10 @@ | |||
|
|
|||
| use Doctrine\DBAL\DBALException; | |||
| use Doctrine\DBAL\Platforms\AbstractPlatform; | |||
| use Doctrine\DBAL\Types\PhpDateTimeMappingType; | |||
There was a problem hiding this comment.
does this exist in the oldest version of doctrine that we support?
There was a problem hiding this comment.
The interface was created in 2018 here: https://github.com/doctrine/dbal/commits/dca1465bdc0836c71ed97e46820490127ccc89ab/lib/Doctrine/DBAL/Types/PhpDateTimeMappingType.php
The interface and default value desired in this PR is implemented originally here: doctrine/dbal@9e75bb0#diff-485a2415348fbc0e83be9feae953842b696202061ea7bf321568f2c0934a2fbdR2285 |
This PR implements PhpDateTimeMappingType for TimestampType, which allows us to use
CURRENT_TIMESTAMPas the default value when changing a column (DBAL)Without this change
CURRENT_TIMSTAMPis treated as a string