-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Revert primary key stuff #37826
Conversation
@driesvints With all due respect, I think you are in a hurry to revert. Please consider this issue #33238 and @taylorotwell invited to solve that problem. |
@taylorotwell The package name: Also, there is an issue and PR in that package to solve this problem. The two other bugs are fixed with tiny changes. |
I had to lock back to 8.47.0 to avoid |
@Shkeats , If you would share the failed migration, I may fix it. |
@khalilst I don't think it's really a scalable approach for you to rewrite everyone's migrations, although the offer is appreciated! |
We don't have |
@Shkeats can you try the new release we just made? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@driesvints I'm still seeing 8.48.1 as latest from what I can tell? I tried applying this change locally but it didn't help in my case. |
@khalilst we have to revert this. We have more people in this thread reporting breakages that aren't related to a package. Laravel is used by many many thousands of applications and I can't just leave them broken. Sorry. |
@khalilst would be willing to explore this again at a later time but it clearly needs more thorough exploration of what these breaking changes are. |
@taylorotwell I'm just trying to fix the issues, but as you can see here @Shkeats even did not provide enough information and I think it was not a good idea to consider it as a breaking change! BWT, Thank you so much and I think you have good reasons to do this. |
@taylorotwell Sure, I will create a package and after resolving all bugs, I will create another PR for this thread. |
This reverts #37715 & #37782.
Fixes #37820 #37811 #37781