[8.x] Order of Modifiers Amended #37782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unsigned() was added to a migration with an integer() or bigInteger(), the order of modifiers would result in a query like: ```sql `field` int primary key unsigned not null ``` This is invalid SQL and therefore caused errors on the migrations. Issue reported, with steps to replicate, here: #37781
GrahamCampbell
changed the title
|
This breaks our deployments so we have rolled back to |
|
@driesvints , @onelazydev Yes, unfortunately right. I am trying to create tests to check all modifiers. |
|
Released 8.48.1 with this fix. |
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Jun 24, 2021
When unsigned() was added to a migration with an integer() or bigInteger(), the order of modifiers would result in a query like: ```sql `field` int primary key unsigned not null ``` This is invalid SQL and therefore caused errors on the migrations. Issue reported, with steps to replicate, here: laravel#37781
driesvints
added a commit
that referenced
this pull request
Jun 25, 2021
This reverts commit 48ce53f.
chu121su12
added a commit
to chu121su12/framework
that referenced
this pull request
Jun 26, 2021
This reverts commit 06c868c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unsigned() was added to a migration with an integer() or bigInteger(), the
order of modifiers would result in a query like:
This is invalid SQL and therefore caused errors on the migrations.
Issue reported, with steps to replicate, here:
#37781