Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Set chain queue and connection only when explicitly configured #35047

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Nov 1, 2020

This PR fixes #35041

It sets the chain queue and connection only when specified. Otherwise the dispatcher will push each job in the chain to the queue/connection assigned to it.

@hivokas
Copy link
Contributor

hivokas commented Nov 1, 2020

Should we also do the same with delay and maybe other properties?

@themsaid
Copy link
Member Author

themsaid commented Nov 2, 2020

@hivokas did it for delay as well.

@taylorotwell
Copy link
Member

Is this the behavior we want? For example, if I do:

Bus::chain([
    (new Job1)->onQueue('foo'),
    new Job2,
])->onQueue('bar');

Don't I want Job1 to still run on the foo queue since I explicitly specified it? While Job2 would run on the bar queue since it had no explicit queue specification?

@taylorotwell taylorotwell merged commit 2811c49 into laravel:8.x Nov 2, 2020
@hivokas
Copy link
Contributor

hivokas commented Nov 2, 2020

@taylorotwell @themsaid thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8.x] Enexpected withChain(...) behaviour
3 participants