[8.x] Enexpected withChain(...) behaviour

[hivokas]

• Laravel Version: 8.12.3
• PHP Version: 7.4.11
• Database Driver & Version: mysql Ver 8.0.19 for macos10.15 on x86_64 (MySQL Community Server - GPL)

Description:

There are 3 classes:

Base job

<?php

namespace App\Jobs;

use Illuminate\Bus\Queueable;

abstract class BaseJob
{
    use Queueable;
}

JobHigh that should be processed in the high queue

<?php

namespace App\Jobs;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;

class JobHigh extends BaseJob implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, SerializesModels;

    public $queue = 'high';

    public function handle()
    {
        //
    }
}

JobMedium that should be processed in the medium queue

<?php

namespace App\Jobs;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;

class JobMedium extends BaseJob implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, SerializesModels;

    public $queue = 'medium';

    public function handle()
    {
        //
    }
}

While in Laravel 7 (7.28.4) both dispatch(new JobHigh); dispatch(new JobMedium); and JobHigh::withChain(new JobMedium)->dispatch() throw jobs to the appropriate queues, in Laravel 8 (8.12.3) that's not a case for withChain(...).

Is that a bug? Or that's a change that was accidentally not included Upgrade Guide.

Steps To Reproduce:

dispatch(new JobHigh);

dispatch(new JobMedium);

Laravel 7:

Laravel 8:

JobHigh::withChain([
    new JobMedium,
])->dispatch();

Laravel 7:

Laravel 8:

[hivokas]

Looks like the problem lays here:

framework/src/Illuminate/Foundation/Bus/PendingChain.php

Lines 136 to 153 in 363dc94

	public function dispatch()
	{
	if (is_string($this->job)) {
	$firstJob = new $this->job(...func_get_args());
	} elseif ($this->job instanceof Closure) {
	$firstJob = CallQueuedClosure::create($this->job);
	} else {
	$firstJob = $this->job;
	}
	$firstJob->allOnConnection($this->connection);
	$firstJob->allOnQueue($this->queue);
	$firstJob->chain($this->chain);
	$firstJob->delay($this->delay);
	$firstJob->chainCatchCallbacks = $this->catchCallbacks();
	return app(Dispatcher::class)->dispatch($firstJob);
	}

Here we are force-overriding the queue even if it was not specified (like here: JobHigh::withChain(new JobMedium)->onQueue('low')->dispatch()):

$firstJob->allOnConnection($this->connection); 
$firstJob->allOnQueue($this->queue); 

Should we do something like that?

if ($this->connection !== null) {
    $firstJob->allOnConnection($this->connection);
}

if ($this->queue !== null) {
    $firstJob->allOnQueue($this->queue);
}

[taylorotwell]

@themsaid

[themsaid]

Opened #35047 with a fix