Fix Str::startsWith() end endsWith() with empty needles #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why should "endsWIth" always return true if you pass an empty string? |
|
What interests me the most is that these functions have the same (and determined) behaviour with this use case, whether it's returning true, false, producing a warning or throwing an invalidargumentexception. |
|
They should return false IMO. — On Sun, Nov 3, 2013 at 2:14 PM, vlakoff [email protected] wrote:
|
|
My gut tells me that they should return false. (and that I'm hungry.) |
The behavior in these cases has been unified: - return false - no longer produce warnings
|
PR updated. Return false, no warnings. As more, endsWith() optimization and docblock tidying :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2627.
Also includes a code optimization.