Standardize Str::startsWith() and endsWith() with empty needle

[vlakoff]

Currently, starts_with('foobar', '') throws a warning (and returns false) and ends_with('foobar', '') returns true.

I think the warning should be removed, and the return value of these cases unified.

And, per this answer on stackoverflow:
Java and .NET implementations of String.StartsWith and String.EndsWith return true if needle is an empty string.

[vlakoff]

Also, for the curious: why it returns true.

[vlakoff]

Str::contains('foobar', '') could be fixed similarly. It currently produces a warning.

Please note that PHP function strpos('foobar', '') produce a warning, contrarily to Java and .NET 's indexOf() which return true.

So, we have two solutions for Laravel's contains(), startsWith() and endsWith():

• Act like PHP and don't support empty needles
• Act like Java and .NET and return true. PHP's strpos() being the exception.

Your opinion on this?