Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fortran preprocessor for fortran interface and then add same l… #308

Merged
merged 22 commits into from
Oct 31, 2023

Conversation

dholladay00
Copy link
Collaborator

@dholladay00 dholladay00 commented Oct 12, 2023

…ogic in fortran interface as is in the c/c++ interface.

PR Summary

Fortran interface build issues can abound when certain Eos's are disabled via preprocessor macros. This PR enables the preprocessor in the fortran interface and adds the same preprocessor logic that exists in the c/c++ interface files in the fortran interface files to resolve fortran build/link issues.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add to the changelog. Other than that LGTM. Click the button when you're happy with it.

Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make these changes in #278, and making them a separate MR is probably a good idea.

I also forgot that the Helmholtz EOS requires spiner

@jhp-lanl
Copy link
Collaborator

@dholladay00 we can pull the trigger when you tell us this is ready

@jhp-lanl
Copy link
Collaborator

@dholladay00 is there anything holding this MR up or can we merge?

@dholladay00 dholladay00 mentioned this pull request Oct 31, 2023
@dholladay00
Copy link
Collaborator Author

This is ready to merge @jhp-lanl

@jhp-lanl jhp-lanl merged commit 4e214d1 into main Oct 31, 2023
4 checks passed
@jhp-lanl jhp-lanl deleted the dholladay00/fpp branch October 31, 2023 22:23
@jhp-lanl
Copy link
Collaborator

Thanks @dholladay00 !

@jhp-lanl jhp-lanl mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants