-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fortran preprocessor for fortran interface and then add same l… #308
Conversation
…ogic in fortran interface as is in the c/c++ interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to add to the changelog. Other than that LGTM. Click the button when you're happy with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make these changes in #278, and making them a separate MR is probably a good idea.
I also forgot that the Helmholtz EOS requires spiner
@dholladay00 we can pull the trigger when you tell us this is ready |
…arity-eos/eos/modifiers/ramps_eos.hpp
…ated. The array compare now showns all digits on printout. Change == to isclose, intel tests were failing otherwise. Also format.
…rtran interface and introduce it to cmake. Make the fortran interface have optional modifier parameters.
@dholladay00 is there anything holding this MR up or can we merge? |
This is ready to merge @jhp-lanl |
Thanks @dholladay00 ! |
…ogic in fortran interface as is in the c/c++ interface.
PR Summary
Fortran interface build issues can abound when certain Eos's are disabled via preprocessor macros. This PR enables the preprocessor in the fortran interface and adds the same preprocessor logic that exists in the c/c++ interface files in the fortran interface files to resolve fortran build/link issues.
PR Checklist
make format
command after configuring withcmake
.