Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortran interface test #284

Closed
jhp-lanl opened this issue Aug 2, 2023 · 1 comment
Closed

Fortran interface test #284

jhp-lanl opened this issue Aug 2, 2023 · 1 comment
Assignees
@Yurlungur @dholladay00 @jonahm-LANL @jhp-lanl
Labels
bug Something isn't working interface Library interface work Testing Additions/changes to the testing infrastruture

Comments

@jhp-lanl
Copy link
Collaborator

jhp-lanl commented Aug 2, 2023

A recent EOS was merged (#269) that included a fortran interface but lacked the C++ function that the interface would call. This was only discovered when trying to link singularity-eos to a Fortran-based host code (that wouldn't even be calling this particular EOS).

This points to a need to compile the fortran interface in some form for our tests so that issues like this don't happen in the future.

FYI - @Yurlungur @dholladay00
@jhp-lanl jhp-lanl added bug Something isn't working Testing Additions/changes to the testing infrastruture interface Library interface work labels Aug 2, 2023
@AlexHls AlexHls mentioned this issue Aug 17, 2023
Merged
6 tasks
@jhp-lanl
Copy link
Collaborator Author

I believe @dholladay00 has fixed this in #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yurlungur Yurlungur

@dholladay00 dholladay00

@jonahm-LANL jonahm-LANL

@jhp-lanl jhp-lanl

Labels
bug Something isn't working interface Library interface work Testing Additions/changes to the testing infrastruture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Yurlungur @dholladay00 @jonahm-LANL @jhp-lanl