Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for /tmp or /var/tmp #885

Merged
merged 4 commits into from
Aug 13, 2024
Merged

added check for /tmp or /var/tmp #885

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f71de45
added check for /var or /var/tmp
Jul 23, 2024
04c30bc
fixed f string linting
Jul 23, 2024
9fc495b
Merge branch 'develop' into Issue870/workdir-not-var
Aug 1, 2024
9f9b068
added update
Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions beeflow/client/bee_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,12 @@ def is_parent(parent, path):
if not os.path.exists(workdir):
error_exit(f"Workflow working directory \"{workdir}\" doesn't exist")

# Make sure the workdir is not in /var or /var/tmp
if os.path.commonpath([os.path.realpath('/tmp'), workdir]) == os.path.realpath('/tmp'):
error_exit("Workflow working directory cannot be in \"/tmp\"")
if os.path.commonpath([os.path.realpath('/var/tmp'), workdir]) == os.path.realpath('/var/tmp'):
error_exit("Workflow working directory cannot be in \"/var/tmp\"")

# TODO: Can all of this information be sent as a file?
data = {
'wf_name': wf_name.encode(),
Expand Down