Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for /tmp or /var/tmp #885

Merged
merged 4 commits into from
Aug 13, 2024
Merged

added check for /tmp or /var/tmp #885

merged 4 commits into from
Aug 13, 2024

Conversation

Leahh02
Copy link
Collaborator

@Leahh02 Leahh02 commented Jul 23, 2024

Checks if the workdir is /tmp or /var/tmp and send an error_exit if it is. Takes into account when /tmp or /var/tmp are symbolic links pointing to another directory. For example my /tmp points to /ram/tmp and my /var/tmp points to /ram/var/tmp. I wasn't sure if the symbolic links would be the same on other clusters, so I made it general.

@Leahh02 Leahh02 requested review from pagrubel and jtronge July 23, 2024 15:00
Copy link
Collaborator

@rstyd rstyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke with Leah offline. This is almost perfect, but we want to verify that the workdir isn't in /tmp or /var/tmp.

@rstyd rstyd self-requested a review August 13, 2024 17:15
Copy link
Collaborator

@rstyd rstyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly! Approved!

@rstyd rstyd merged commit 56fe02e into develop Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants