py tracer fixes #5377
Merged
py tracer fixes #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vowelparrot
approved these changes
May 29, 2023
vowelparrot
approved these changes
May 29, 2023
nfcampos
reviewed
May 30, 2023
| raise_for_status_with_text(response) | ||
| response = None | ||
| try: | ||
| response = requests.get(endpoint_ + "/tenants", headers=headers_) |
There was a problem hiding this comment.
Shouldn't this be removed, or is that another PR?
nfcampos
reviewed
May 30, 2023
| @@ -72,6 +119,8 @@ def __init__( | |||
| self.example_id = example_id | |||
| self.session_name = session_name or os.getenv("LANGCHAIN_SESSION", "default") | |||
| self.session_extra = session_extra | |||
| # set max_workers to 1 to process tasks in order | |||
There was a problem hiding this comment.
Why does order matter? Can we rely on every user of the api being as strict about order as we are being here?
There was a problem hiding this comment.
It'll fail if a child run gets posted before a parent run at least, right? (parent_run_id not found)
vowelparrot
reviewed
May 30, 2023
| run_dict = run.dict() | ||
| del run_dict["child_runs"] | ||
| run_create = RunCreate(**run_dict, session_id=session.id) | ||
| run.reference_example_id = self.example_id |
There was a problem hiding this comment.
For this, (I think) we should be only assigning if there is no parent_run_id, otherwise it links all the nested child runs to an example
vowelparrot
pushed a commit
that referenced
this pull request
May 31, 2023
9 tasks
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not merging yet due to two issues:
cc @vowelparrot