Add Patch to stream runs #4697
Closed
Add Patch to stream runs #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agola11
approved these changes
May 15, 2023
| @@ -45,19 +50,23 @@ def _start_trace(self, run: Run) -> None: | |||
| f"Parent run with UUID {run.parent_run_id} not found." | |||
| ) | |||
| self.run_map[str(run.id)] = run | |||
| self._persist_partial_run(run) | |||
There was a problem hiding this comment.
Let's discuss this a bit more tomorrow. I wonder if logging to the backend on every start this way might add extra unwanted latency. I would hold off on this until we have a better solution, might be use to use a combination of asyncio.create_task and asyncio.Queue for this cc @nfcampos
agola11
reviewed
May 15, 2023
|
Will Close in lieu of #5377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Create -> Patch flow for real-time tracing