community: Fix a validation error for MoonshotChat #27801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR langchain-ai#17100, the implementation for Moonshot was added, which defined two classes: - `MoonshotChat(MoonshotCommon, ChatOpenAI)` in `langchain_community.chat_models.moonshot`; - Here, `validate_environment()` assigns **client** as `openai.OpenAI().chat.completions` - Note that **client** here is actually a member variable defined in `ChatOpenAI`; - `MoonshotCommon` in `langchain_community.llms.moonshot`; - And here, `validate_environment()` assigns **_client** as `_MoonshotClient`; - Note that this is the underscored **_client**, which is defined within `MoonshotCommon` itself; At this time, there was no conflict between the two, one being `client` and the other `_client`. However, in PR langchain-ai#25878 which fixed langchain-ai#24390, `_client` in `MoonshotCommon` was changed to `client`. Since then, a conflict in the definition of `client` has arisen between `MoonshotCommon` and `MoonshotChat`, which caused `pydantic` validation error. To fix this issue, the type of `client` in `MoonshotCommon` should be changed to `Any`. Signed-off-by: Tao Wang <[email protected]>
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
community
ccurme
approved these changes
Oct 31, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MoonshotCommon.clienttype from_MoonshotClienttoAny.In PR #17100, the implementation for Moonshot was added, which defined two classes:
MoonshotChat(MoonshotCommon, ChatOpenAI)inlangchain_community.chat_models.moonshot;validate_environment()assigns client asopenai.OpenAI().chat.completionsChatOpenAI;MoonshotCommoninlangchain_community.llms.moonshot;validate_environment()assigns _client as_MoonshotClient;MoonshotCommonitself;At this time, there was no conflict between the two, one being
clientand the other_client.However, in PR #25878 which fixed #24390,
_clientinMoonshotCommonwas changed toclient. Since then, a conflict in the definition ofclienthas arisen betweenMoonshotCommonandMoonshotChat, which causedpydanticvalidation error.To fix this issue, the type of
clientinMoonshotCommonshould be changed toAny.