Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs, langchain-unstructured: update langchain-unstructured docs and update ustructured-client dependency #25451

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

Coniferish
Copy link
Contributor

@Coniferish Coniferish commented Aug 15, 2024

Be more explicit in the docs about creating an instance of the UnstructuredClient if you want to customize it versus using sdk parameters with the UnstructuredLoader.

Bump the unstructured-client dependency as discussed here

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 15, 2024
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 8:36pm

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Aug 15, 2024
@Coniferish Coniferish marked this pull request as draft August 15, 2024 18:17
@efriis efriis added the partner label Aug 15, 2024
@efriis efriis self-assigned this Aug 15, 2024
@Coniferish
Copy link
Contributor Author

Coniferish commented Aug 16, 2024

I was receiving the following error when trying to run make format (and make lint) from within the partners/unstructured/ directory, so I updated the Makefile

poetry run ruff format .
10 files left unchanged
poetry run ruff --select I --fix .
error: `ruff <path>` has been removed. Use `ruff check <path>` instead.
make: *** [format] Error 1

@Coniferish Coniferish changed the title docs: update langchain-unstructured docs docs, langchain-unstructured: update langchain-unstructured docs and update ustructured-client dependency Aug 16, 2024
@cbornet
Copy link
Collaborator

cbornet commented Aug 16, 2024

I was receiving the following error when trying to run make format (and make lint) from within the partners/unstructured/ directory, so I updated the Makefile

That's because your new poetry.lock bumps the ruff version to 0.5+.
It would be good to ensure that ruff 0.5+ is always pulled by changing ruff = "^0.1.8" to ruff = "^0.5"

@Coniferish
Copy link
Contributor Author

@cbornet, thanks for the comments. CI is still failing with the same error, but I'm unsure what to make of it. Do you have any guidance for me on that?

@cbornet
Copy link
Collaborator

cbornet commented Aug 16, 2024

I think the CI error is not related to your PR.
I have the same in #25344
It seems a CI runner runs out of memory.

@Coniferish
Copy link
Contributor Author

I think the CI error is not related to your PR. I have the same in #25344 It seems a CI runner runs out of memory.

Sounds good. Please let me know if there's anything I need to do to resolve it

@Coniferish Coniferish marked this pull request as ready for review August 16, 2024 19:00
@dosubot dosubot bot added the Ɑ: doc loader Related to document loader module (not documentation) label Aug 16, 2024
Be more explicit in the docs about having to create an instance of the UnstructuredClient if you want to customize how it is used by the UnstructuredLoader
@Coniferish
Copy link
Contributor Author

@cbornet, I've rebased onto master to resolve the merge conflicts that were occurring. Do you think we can get this merged today once the tests pass?

@cbornet
Copy link
Collaborator

cbornet commented Aug 23, 2024

I don’t have merge permissions on LangChain 🙂.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 23, 2024
@efriis efriis enabled auto-merge (squash) August 23, 2024 20:20
@efriis efriis merged commit 5ce9a71 into langchain-ai:master Aug 23, 2024
18 checks passed
@Coniferish Coniferish deleted the jj/docs branch August 23, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants