all: Improve make lint command #25344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
cbornet
force-pushed
the
make-lint
branch
5 times, most recently
from
5083c2b to
a9a31dc
Compare
|
It seems one of the CI runner is out of memory. |
cbornet
force-pushed
the
make-lint
branch
2 times, most recently
from
daa270f to
9002844
Compare
cbornet
changed the title
efriis
approved these changes
Aug 24, 2024
dosubot
bot
added
the
lgtm
baskaryan
reviewed
Aug 24, 2024
| poetry run ruff format $(PYTHON_FILES) --diff | ||
| poetry run ruff --select I $(PYTHON_FILES) | ||
| mkdir -p $(MYPY_CACHE); poetry run mypy $(PYTHON_FILES) --cache-dir $(MYPY_CACHE) | ||
| [ "$(PYTHON_FILES)" = "" ] || poetry run ruff $(PYTHON_FILES) |
There was a problem hiding this comment.
should this be run ruff check ...
There was a problem hiding this comment.
Yes, it think it should.
I can open another PR for it.
|
bypassing ai21 - known issue in their underlying sdk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff check --select IasIis already selected and checked in the mainruff checkcommandPYTHON_FILESruff checkonly onPYTHON_FILES