[Community]: Added classification_location parameter in PebbloSafeLoader. #22565
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
7 times, most recently
from
e912a70
to
8ca58df
Compare
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
2 times, most recently
from
ae09530
to
5544b59
Compare
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
…loRetrievalQA. Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
from
1b13f3a
to
7729af6
Compare
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
dosubot
bot
added
size:L
|
Hi @baskaryan |
rahul-trip
changed the title
Signed-off-by: Rahul Tripathi <[email protected]>
|
Hi @eyurtsev, @hwchase17 |
Signed-off-by: Rahul Tripathi <[email protected]>
|
@Raj725 are you able to review? |
|
@rahul-trip if you're working at daxa-ai, merge time can be significantly reduced by getting another daxa-ai engineer to review the changes |
| @@ -321,38 +333,44 @@ def _get_app_details(app_name, owner, description, llm, **kwargs) -> App: # typ | |||
| return app | |||
|
|
|||
| @staticmethod | |||
| def _send_discover(app, api_key, classifier_url) -> None: # type: ignore | |||
| def _send_discover(app, api_key, classifier_url, classifier_location) -> None: # type: ignore | |||
There was a problem hiding this comment.
type annotations missing here
There was a problem hiding this comment.
Added missing type annotations throughout file.
| @@ -150,6 +150,7 @@ class Doc(BaseModel): | |||
| loader_details: dict | |||
| loading_end: bool | |||
| source_owner: str | |||
| classifier_location: str | |||
There was a problem hiding this comment.
- Could you update the doc-string?
- The doc-strings should be below the attribute not in the model doc-string
There was a problem hiding this comment.
Updated all the models with suggested doc-string style.
| @@ -46,6 +46,7 @@ def __init__( | |||
| api_key: Optional[str] = None, | |||
| load_semantic: bool = False, | |||
| classifier_url: Optional[str] = None, | |||
| classifier_location: str = "local", | |||
There was a problem hiding this comment.
Use * prior to new named arguments
There was a problem hiding this comment.
Added as suggested.
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
3 times, most recently
from
7919297
to
1903c15
Compare
@eyurtsev we do review each PR internally and post the branch here only when internal review is approved (we do this in our fork.). From now on, we will start the approval process here as suggested. @Raj725, please check if you are able to approve. |
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
from
1903c15
to
50c835b
Compare
|
@rahul-trip / @Raj725 thanks! Your existing process is great. Mainly helpful to see a final sign off from another person on the team! |
…feLoader. (langchain-ai#22565) Description: Add classifier_location feature flag. This flag enables Pebblo to decide the classifier location, local or pebblo-cloud. Unit Tests: N/A Documentation: N/A --------- Signed-off-by: Rahul Tripathi <[email protected]> Co-authored-by: Rahul Tripathi <[email protected]>
…feLoader. (langchain-ai#22565) Description: Add classifier_location feature flag. This flag enables Pebblo to decide the classifier location, local or pebblo-cloud. Unit Tests: N/A Documentation: N/A --------- Signed-off-by: Rahul Tripathi <[email protected]> Co-authored-by: Rahul Tripathi <[email protected]>
Description: Add classifier_location feature flag. This flag enables Pebblo to decide the classifier location, local or pebblo-cloud.
Unit Tests: N/A
Documentation: N/A