Added classification_location parameter in PebbloSafeLoader. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
5 times, most recently
from
bb467fb to
30c51e2
Compare
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
4 times, most recently
from
ae09530 to
5544b59
Compare
added 5 commits
June 17, 2024 23:09
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
…loRetrievalQA. Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
from
1b13f3a to
7729af6
Compare
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
Raj725
reviewed
Jun 20, 2024
| _discover_sent: bool = False #: :meta private: | ||
| classifier_location: str = "local" #: :meta private: | ||
| """Classifier location. It could be either of 'local' or 'pebblo-cloud'.""" | ||
| _discover_sent = False #: :meta private: |
There was a problem hiding this comment.
What is the use of _discover_sent and _prompt_sent? They are only set and never used in the code. Additionally, since these are class-level variables, how will they work with multiple prompt requests?
There was a problem hiding this comment.
These flags are not intended to be used within the code, but by the end user.
The end user user can check the status of discovery or prompt/document payload sent successfully or not.
Currently they are only for pebblo-server, can be enhanced for pebblo-cloud as well.
To fix _prompt_sent, now I have intentionally set it to False in the beginning of _call method.
added 2 commits
June 21, 2024 01:58
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
3 times, most recently
from
7919297 to
1903c15
Compare
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/classification_location
branch
from
1903c15 to
50c835b
Compare
|
Closing this PR since the changes are already merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add classifier_url parameter in PebbloSafeLoader, It enables following flow of code execution.