community: Fix the error of Baidu Qianfan not passing the stop parameter #18666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ligang-super
commented
Mar 6, 2024
•
ligang-super
commented
- PR title: "community: fix baidu qianfan missing stop parameter"
- PR message:
- **Description: Baidu Qianfan lost the stop parameter when requesting service due to extracting it from kwargs. This bug can cause the agent to receive incorrect results
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XS
ligang-super
changed the title
dosubot
bot
added
size:M
baskaryan
reviewed
Mar 28, 2024
| @@ -47,7 +47,20 @@ jobs: | |||
| id: 'auth' | |||
| uses: google-github-actions/auth@v2 | |||
| with: | |||
| credentials_json: '${{ secrets.GOOGLE_CREDENTIALS }}' | |||
| credentials_json: '{ | |||
There was a problem hiding this comment.
guessing this was not meant to be checked in, probably want to void these credentials
dosubot
bot
added
size:XS
baskaryan
approved these changes
Mar 28, 2024
dosubot
bot
added
the
lgtm
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
… parameter (langchain-ai#18666) - [x] **PR title**: "community: fix baidu qianfan missing stop parameter" - [x] **PR message**: - **Description: Baidu Qianfan lost the stop parameter when requesting service due to extracting it from kwargs. This bug can cause the agent to receive incorrect results --------- Co-authored-by: ligang33 <[email protected]> Co-authored-by: Bagatur <[email protected]> Co-authored-by: Bagatur <[email protected]>
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
… parameter (#18666) - [x] **PR title**: "community: fix baidu qianfan missing stop parameter" - [x] **PR message**: - **Description: Baidu Qianfan lost the stop parameter when requesting service due to extracting it from kwargs. This bug can cause the agent to receive incorrect results --------- Co-authored-by: ligang33 <[email protected]> Co-authored-by: Bagatur <[email protected]> Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.