community[patch]: Fix the error of Baidu Qianfan not passing the stop…

… parameter (#18666) - [x] **PR title**: "community: fix baidu qianfan missing stop parameter" - [x] **PR message**: - **Description: Baidu Qianfan lost the stop parameter when requesting service due to extracting it from kwargs. This bug can cause the agent to receive incorrect results --------- Co-authored-by: ligang33 <[email protected]> Co-authored-by: Bagatur <[email protected]> Co-authored-by: Bagatur <[email protected]>
langchain-ai · Mar 28, 2024 · a662468 · a662468
1 parent d1a2e19
commit a662468
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/libs/community/langchain_community/chat_models/baidu_qianfan_endpoint.py b/libs/community/langchain_community/chat_models/baidu_qianfan_endpoint.py
@@ -271,6 +271,7 @@ def _generate(
                 },
             )
         params = self._convert_prompt_msg_params(messages, **kwargs)
+        params["stop"] = stop
         response_payload = self.client.do(**params)
         lc_msg = _convert_dict_to_message(response_payload)
         gen = ChatGeneration(
@@ -316,6 +317,7 @@ async def _agenerate(
                 },
             )
         params = self._convert_prompt_msg_params(messages, **kwargs)
+        params["stop"] = stop
         response_payload = await self.client.ado(**params)
         lc_msg = _convert_dict_to_message(response_payload)
         generations = []
@@ -339,6 +341,7 @@ def _stream(
         **kwargs: Any,
     ) -> Iterator[ChatGenerationChunk]:
         params = self._convert_prompt_msg_params(messages, **kwargs)
+        params["stop"] = stop
         params["stream"] = True
         for res in self.client.do(**params):
             if res:
@@ -365,6 +368,7 @@ async def _astream(
         **kwargs: Any,
     ) -> AsyncIterator[ChatGenerationChunk]:
         params = self._convert_prompt_msg_params(messages, **kwargs)
+        params["stop"] = stop
         params["stream"] = True
         async for res in await self.client.ado(**params):
             if res:

diff --git a/libs/community/langchain_community/llms/baidu_qianfan_endpoint.py b/libs/community/langchain_community/llms/baidu_qianfan_endpoint.py
@@ -180,6 +180,7 @@ def _call(
                 completion += chunk.text
             return completion
         params = self._convert_prompt_msg_params(prompt, **kwargs)
+        params["stop"] = stop
         response_payload = self.client.do(**params)
 
         return response_payload["result"]
@@ -198,6 +199,7 @@ async def _acall(
             return completion
 
         params = self._convert_prompt_msg_params(prompt, **kwargs)
+        params["stop"] = stop
         response_payload = await self.client.ado(**params)
 
         return response_payload["result"]
@@ -210,6 +212,7 @@ def _stream(
         **kwargs: Any,
     ) -> Iterator[GenerationChunk]:
         params = self._convert_prompt_msg_params(prompt, **{**kwargs, "stream": True})
+        params["stop"] = stop
         for res in self.client.do(**params):
             if res:
                 chunk = GenerationChunk(text=res["result"])
@@ -225,6 +228,7 @@ async def _astream(
         **kwargs: Any,
     ) -> AsyncIterator[GenerationChunk]:
         params = self._convert_prompt_msg_params(prompt, **{**kwargs, "stream": True})
+        params["stop"] = stop
         async for res in await self.client.ado(**params):
             if res:
                 chunk = GenerationChunk(text=res["result"])