-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: model init ValueError #13439
Closed
vvanglro
wants to merge
12
commits into
langchain-ai:master
from
vvanglro:fix/model_init_private_attributes
Closed
fix: model init ValueError #13439
vvanglro
wants to merge
12
commits into
langchain-ai:master
from
vvanglro:fix/model_init_private_attributes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
Related to LLMs or chat model modules
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
labels
Nov 16, 2023
@baskaryan Please run ci again. |
Hi @baskaryan. |
Sorry for the bug, Thanks for fixing it. |
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 28, 2023
@baskaryan Please review. |
hwchase17
reviewed
Nov 29, 2023
hwchase17
added a commit
that referenced
this pull request
Dec 5, 2023
- **Description:** Added masking for the API key for Minimax LLM + tests inspired by #12418. - **Issue:** the issue # fixes #12165 - **Dependencies:** this fix is dependent on Minimax instantiation fix which is introduced in #13439, so merge this one after. - **Tag maintainer:** @eyurtsev --------- Co-authored-by: Harrison Chase <[email protected]>
dosubot
bot
removed
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Dec 6, 2023
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Dec 6, 2023
aymeric-roucher
pushed a commit
to andrewrreed/langchain
that referenced
this pull request
Dec 11, 2023
- **Description:** Added masking for the API key for Minimax LLM + tests inspired by langchain-ai#12418. - **Issue:** the issue # fixes langchain-ai#12165 - **Dependencies:** this fix is dependent on Minimax instantiation fix which is introduced in langchain-ai#13439, so merge this one after. - **Tag maintainer:** @eyurtsev --------- Co-authored-by: Harrison Chase <[email protected]>
looks like this has been fixed, ok to close @vvanglro? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix #13438 #11648 #10917