Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model init ValueError #13439

Closed

Conversation

vvanglro
Copy link

@vvanglro vvanglro commented Nov 16, 2023

This pr fix #13438 #11648 #10917

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2023 6:14am

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Nov 16, 2023
@baskaryan
Copy link
Collaborator

cc @hetaoBackend

@vvanglro
Copy link
Author

@baskaryan Please run ci again.

@vvanglro
Copy link
Author

vvanglro commented Nov 20, 2023

Hi @baskaryan.
I investigated the entire revision history, The cause of the error occurred here #10776.
This commit had a fix attempted but didn't find the problem #12554 .

@hetaoBackend
Copy link
Contributor

Sorry for the bug, Thanks for fixing it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 28, 2023
@vvanglro
Copy link
Author

@baskaryan Please review.

hwchase17 added a commit that referenced this pull request Dec 5, 2023
- **Description:** Added masking for the API key for Minimax LLM + tests
inspired by #12418.
- **Issue:** the issue # fixes
#12165
- **Dependencies:** this fix is dependent on Minimax instantiation fix
which is introduced in
#13439, so merge this one
after.
  - **Tag maintainer:** @eyurtsev

---------

Co-authored-by: Harrison Chase <[email protected]>
@dosubot dosubot bot removed the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 6, 2023
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 6, 2023
aymeric-roucher pushed a commit to andrewrreed/langchain that referenced this pull request Dec 11, 2023
- **Description:** Added masking for the API key for Minimax LLM + tests
inspired by langchain-ai#12418.
- **Issue:** the issue # fixes
langchain-ai#12165
- **Dependencies:** this fix is dependent on Minimax instantiation fix
which is introduced in
langchain-ai#13439, so merge this one
after.
  - **Tag maintainer:** @eyurtsev

---------

Co-authored-by: Harrison Chase <[email protected]>
@baskaryan
Copy link
Collaborator

baskaryan commented Jan 29, 2024

looks like this has been fixed, ok to close @vvanglro?

@vvanglro vvanglro closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: models Related to LLMs or chat model modules size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model init ValueError
4 participants