Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: fix the issue #11648 init minimax llm #12554

Merged

Conversation

mingforpc
Copy link
Contributor

Fix Issue #11648 Minimax llm failed to initialize

The idea of this fix is #10917 (comment)

do not use underscore in python model class

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 9:22pm

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Oct 30, 2023
@mingforpc mingforpc changed the title **Issue:** the issue #11648 it fixes Issue: fix the issue #11648 init minimax llm Oct 30, 2023
@baskaryan baskaryan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 30, 2023
@baskaryan
Copy link
Collaborator

thanks @mingforpc!

@baskaryan baskaryan merged commit 13b8981 into langchain-ai:master Oct 30, 2023
@qkxie
Copy link

qkxie commented Nov 15, 2023

image
image

langchain==0.0.335

Issue still exists. Your commit does not solve this problem.

@vvanglro
Copy link

langchain==0.0.335

Issue still exists. Your commit does not solve this problem.

#13439 This PR will fix.

xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
…i#12554)

e langchain-ai#11648 Minimax
llm failed to initialize

The idea of this fix is
langchain-ai#10917 (comment)

do not use  underscore in python model class

---------

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Bagatur <[email protected]>
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
…i#12554)

e langchain-ai#11648 Minimax
llm failed to initialize

The idea of this fix is
langchain-ai#10917 (comment)

do not use  underscore in python model class

---------

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Bagatur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: models Related to LLMs or chat model modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants