Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javelin #10275

Merged
merged 39 commits into from
Sep 20, 2023
Merged

Javelin #10275

merged 39 commits into from
Sep 20, 2023

Conversation

rsharath
Copy link
Contributor

@rsharath rsharath commented Sep 6, 2023

No description provided.

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 10:54pm

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Sep 6, 2023
tomasonjo and others added 15 commits September 7, 2023 02:22
…ai#10292)

Follow-up PR for langchain-ai#10047,
simply adding a notebook quickstart example for the vector store with
SQLite, using the class SQLiteVSS.

Maintainer tag @baskaryan

Co-authored-by: Philippe Oger <[email protected]>
I have updated the code to ensure consistent error handling for
ImportError. Instead of relying on ValueError as before, I've followed
the standard practice of raising ImportError while also including
detailed error messages. This modification improves code clarity and
explicitly indicates that any issues are related to module imports.
1. For passing config to runnable lambda
2. For branching and merging
Fix the import in docmention

---------

Co-authored-by: Bagatur <[email protected]>
langchain-ai#10085
---------

Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Co-authored-by: Bagatur <[email protected]>
Embed documents without locally downloading the HF model


---------

Co-authored-by: Bagatur <[email protected]>
…0260)

- Description: Updated Additional Resources section of documentation and
added to YouTube videos with excellent playlist of Langchain content
from Sam Witteveen
- Issue: None -- updating documentation
- Dependencies: None
- Tag maintainer: @baskaryan
- Description: Remove hardcoded/duplicated distance strategies in the
PGVector store.
- Issue: NA
- Dependencies: NA
- Tag maintainer: for a quicker response, tag the relevant maintainer
(see below),
- Twitter handle: @archmonkeymojo

---------

Co-authored-by: Bagatur <[email protected]>
Huggingface, HuggingFace -> Hugging Face
Split sql use case into directory so we can add other structured data
pages
This PR replaces the generic `SET search_path TO` statement by `USE` for
the Trino dialect since Trino does not support `SET search_path`.
Official Trino documentation can be found
[here](https://trino.io/docs/current/sql/use.html).

With this fix, the `SQLdatabase` will now be able to set the current
schema and execute queries using the Trino engine. It will use the
catalog set as default by the connection uri.
# Description

This pull request allows to use the
[NucliaDB](https://docs.nuclia.dev/docs/docs/nucliadb/intro) as a vector
store in LangChain.

It works with both a [local NucliaDB
instance](https://docs.nuclia.dev/docs/docs/nucliadb/deploy/basics) or
with [Nuclia Cloud](https://nuclia.cloud).

# Dependencies

It requires an up-to-date version of the `nuclia` Python package.

@rlancemartin, @eyurtsev, @hinthornw, please review it when you have a
moment :)

Note: our Twitter handler is `@NucliaAI`
@rsharath
Copy link
Contributor Author

rsharath commented Sep 8, 2023

if you'd like you can also add notebooks to docs/extras/integrations/{chat,llms,embeddings} for the different classes. other than that and the one comment above looks awesome!

done

@baskaryan
Copy link
Collaborator

still some linting issues, happy to take over and land if you'd like @rsharath

@rsharath
Copy link
Contributor Author

rsharath commented Sep 9, 2023

still some linting issues, happy to take over and land if you'd like @rsharath

@baskaryan would really appreciate that, thank you!!

@rsharath
Copy link
Contributor Author

@baskaryan please let me know if you need anything further from my end, looking forward to seeing this live!

Thanks again for the awesome work you folks are doing!

Sharath

@rsharath
Copy link
Contributor Author

@baskaryan / @sbusso - I have updated my PR branch with the latest master and its ready for integration. Please take a look and let me know. Thanks! Sharath

@rsharath
Copy link
Contributor Author

@baskaryan , @hwchase17 - please let me know if I missed anything, but it appears good from my end.

@@ -246,6 +276,13 @@ def _anonymize(self, text: str, language: Optional[str] = None) -> str:

Args:
text: text to anonymize
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldnt be here

@@ -130,7 +130,6 @@ assemblyai = {version = "^0.17.0", optional = true}
dashvector = {version = "^1.0.1", optional = true}
sqlite-vss = {version = "^0.1.2", optional = true}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray deletion

@@ -7,7 +7,11 @@
"source": [
"# Diffbot Graph Transformer\n",
"\n",
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these files shouldnt change

@@ -0,0 +1,151 @@
{
"cells": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this showing up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

{
"cells": [
{
"cell_type": "markdown",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this showing up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted to master

@@ -459,7 +459,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.1"
"version": "3.11.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldnt change

{
"cell_type": "markdown",
"id": "9a9acd2e",
"metadata": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this showing up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this showing up

Fixed

@rsharath
Copy link
Contributor Author

@hwchase17 should be clean, not sure how I missed those stray edits that appears to have crept up during merge with master. Thanks for pointing those out, I have fixed. Appreciate it!

@rsharath
Copy link
Contributor Author

@baskaryan @hwchase17 let me know if we are missing anything else. Thanks!

@baskaryan
Copy link
Collaborator

looks great, thanks @rsharath! you may want to add a notebook at docs/extras/integrations/chat but that can be done in follow up pr

@baskaryan baskaryan merged commit 96023f9 into langchain-ai:master Sep 20, 2023
@rsharath
Copy link
Contributor Author

@baskaryan will this be in tomorrow's release? any chance we can get a shoutout for Javelin AI Gateway in your release/twitter?

@baskaryan
Copy link
Collaborator

@baskaryan will this be in tomorrow's release? any chance we can get a shoutout for Javelin AI Gateway in your release/twitter?

yep and yep!

@rsharath rsharath deleted the javelin branch September 30, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features Ɑ: models Related to LLMs or chat model modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.