Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode PGVector distance strategies #10265

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

brianantonelli
Copy link
Contributor

  • Description: Remove hardcoded/duplicated distance strategies in the PGVector store.
  • Issue: NA
  • Dependencies: NA
  • Tag maintainer: for a quicker response, tag the relevant maintainer (see below),
  • Twitter handle: @archmonkeymojo

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 10:09pm
langchain-deprecated ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 10:09pm

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:improvement Medium size change to existing code to handle new use-cases labels Sep 6, 2023
@baskaryan
Copy link
Collaborator

baskaryan commented Sep 6, 2023

thanks @brianantonelli!

@baskaryan baskaryan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 6, 2023
@baskaryan baskaryan merged commit 4df101c into langchain-ai:master Sep 6, 2023
@brianantonelli brianantonelli deleted the patch-1 branch September 7, 2023 02:25
rsharath pushed a commit to getjavelin/langchain that referenced this pull request Sep 8, 2023
- Description: Remove hardcoded/duplicated distance strategies in the
PGVector store.
- Issue: NA
- Dependencies: NA
- Tag maintainer: for a quicker response, tag the relevant maintainer
(see below),
- Twitter handle: @archmonkeymojo

---------

Co-authored-by: Bagatur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants