Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(executor): Provide simple HTTP executor #7
(executor): Provide simple HTTP executor #7
Changes from all commits
ccb4273
1905495
f12fa34
3f5953e
8b6e70f
0e0919d
4224219
b673ff8
940ca7e
bcd8948
dc5b6ce
17bc61a
9ef2f20
3df2daf
7e949cc
ad613d8
b8a2961
094a81a
44656e4
33f46e8
6be7bef
02f287e
850f4c9
2dc0d66
846a396
fb51ecc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to use
ElasticDocumentResponse
? Not sure if this response is the same for everyElasticRequest
.Also, we need to consider which meta fields we require.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it makes sense to remove all unused fields. We need only
found
andsource
at the moment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will probably need
id
as well but i can remove it for now.