(executor): Provide simple HTTP executor #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmarjanovic
commented
Nov 27, 2022
modules/library/src/main/scala/zio/elasticsearch/ElasticRequest.scala
Outdated
Show resolved
Hide resolved
| import zio.json.ast.Json | ||
| import zio.json.{DeriveJsonDecoder, JsonDecoder, jsonField} | ||
|
|
||
| final case class ElasticResponse( |
There was a problem hiding this comment.
Does it make sense to use ElasticDocumentResponse? Not sure if this response is the same for every ElasticRequest.
Also, we need to consider which meta fields we require.
There was a problem hiding this comment.
Now, it makes sense to remove all unused fields. We need only found and source at the moment.
There was a problem hiding this comment.
We will probably need id as well but i can remove it for now.
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
dbulaja98
force-pushed
the
dsl-put-request
branch
2 times, most recently
from
62d35c1 to
12911f5
Compare
markaya
force-pushed
the
executor-simple-http-executor
branch
from
ac81de6 to
6be7bef
Compare
drmarjanovic
commented
Nov 28, 2022
modules/library/src/main/scala/zio/elasticsearch/ElasticExecutor.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/HttpElasticExecutor.scala
Outdated
Show resolved
Hide resolved
| import zio.json.ast.Json | ||
| import zio.json.{DeriveJsonDecoder, JsonDecoder, jsonField} | ||
|
|
||
| final case class ElasticResponse( |
There was a problem hiding this comment.
Now, it makes sense to remove all unused fields. We need only found and source at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ElasticConfigthat accepts onlyhost: Stringandport: Int..executein theElasticRequestclass.GetById.