Replaced job's OS. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablodeymo
approved these changes
Nov 23, 2023
pablodeymo
added a commit
that referenced
this pull request
Nov 30, 2023
* Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
pablodeymo
added a commit
that referenced
this pull request
Dec 12, 2023
* Added public input evals * Fixes * Absorb public evals * Added combined_evals and others * Added get alphas * Minor * Progress on ft eval * Added combined inner prod * Fixing comb inn prod * Fixed 3d array prob * Fix compile errors: * Add error * README * Deserialize VerifierIndex from KZG prover and fixes (#89) * Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove repeated lines Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove unused import Co-authored-by: Pablo Deymonnaz <[email protected]> * Change o1js submodule commit * Changed commit again * Ethereum verifier continued (#92) * KZG Prover generate verifier index * Deserialize verifier index * Added remaining msgpack primitives * Fix uint deser * Add public_len field * Initialize alphas * Final fixes * Add constraint count for pows of alpha * Added combined evaluations step * Added fake witness * Fixed issues regarding fake witness * Added comments, removed printlns * Satisfy copy constraints * Revert fake witness development * Added test circuit kzg proof * Disable test circuit proof gen * Added vanishing poly * Continuing final comm step * Update proof-systems submodule branch * Solidity verifier development continued (#100) * Added perm scalars * Added PolishToken * Added new test circuit for the KZG prover * Added better comment to polishtoken * RPN progress * Finished preliminary rpn evaluation * Fixes --------- Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
pablodeymo
added a commit
that referenced
this pull request
Dec 13, 2023
* Added public input evals * Fixes * Absorb public evals * Added combined_evals and others * Added get alphas * Minor * Progress on ft eval * Added combined inner prod * Fixing comb inn prod * Fixed 3d array prob * Fix compile errors: * Add error * README * Deserialize VerifierIndex from KZG prover and fixes (#89) * Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove repeated lines Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove unused import Co-authored-by: Pablo Deymonnaz <[email protected]> * Change o1js submodule commit * Changed commit again * Ethereum verifier continued (#92) * KZG Prover generate verifier index * Deserialize verifier index * Added remaining msgpack primitives * Fix uint deser * Add public_len field * Initialize alphas * Final fixes * Add constraint count for pows of alpha * Added combined evaluations step * Added fake witness * Fixed issues regarding fake witness * Added comments, removed printlns * Satisfy copy constraints * Revert fake witness development * Added test circuit kzg proof * Disable test circuit proof gen * Added vanishing poly * Continuing final comm step * Added perm scalars * Added PolishToken * Added new test circuit for the KZG prover * Added better comment to polishtoken * RPN progress * Finished preliminary rpn evaluation * Fixes * Test verifier index from new circuit * WIP fixes for deserialization * Final fixes * Deserialized part of the prover proof * Deserialize public evals * Deserialize rest of evals * Finish deserializing index and proof * Remove duplicated function --------- Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
xqft
added a commit
that referenced
this pull request
Dec 20, 2023
* Added public input evals * Fixes * Absorb public evals * Added combined_evals and others * Added get alphas * Minor * Progress on ft eval * Added combined inner prod * Fixing comb inn prod * Fixed 3d array prob * Fix compile errors: * Add error * README * Deserialize VerifierIndex from KZG prover and fixes (#89) * Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove repeated lines Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove unused import Co-authored-by: Pablo Deymonnaz <[email protected]> * Change o1js submodule commit * Changed commit again * Ethereum verifier continued (#92) * KZG Prover generate verifier index * Deserialize verifier index * Added remaining msgpack primitives * Fix uint deser * Add public_len field * Initialize alphas * Final fixes * Add constraint count for pows of alpha * Added combined evaluations step * Added fake witness * Fixed issues regarding fake witness * Added comments, removed printlns * Satisfy copy constraints * Revert fake witness development * Added test circuit kzg proof * Disable test circuit proof gen * Added vanishing poly * Continuing final comm step * Added perm scalars * Added PolishToken * Added new test circuit for the KZG prover * Added better comment to polishtoken * RPN progress * Finished preliminary rpn evaluation * Fixes * Test verifier index from new circuit * WIP fixes for deserialization * Final fixes * Deserialized part of the prover proof * Deserialize public evals * Deserialize rest of evals * Finish deserializing index and proof * Integrated verifier with deserializer * Added lagrange bases deserialization * Fixes * Added PairingURS and started deser function * Finished writing URS deserializer and forge script * Fix EncodedMap non-string keys * Remove duplicated function * Remove logs * Random URS and lagrange bases * Temporarily remove URS serialization * Small fixes --------- Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
xqft
added a commit
that referenced
this pull request
Dec 21, 2023
* Added public input evals * Fixes * Absorb public evals * Added combined_evals and others * Added get alphas * Minor * Progress on ft eval * Added combined inner prod * Fixing comb inn prod * Fixed 3d array prob * Fix compile errors: * Add error * README * Deserialize VerifierIndex from KZG prover and fixes (#89) * Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove repeated lines Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove unused import Co-authored-by: Pablo Deymonnaz <[email protected]> * Change o1js submodule commit * Changed commit again * Ethereum verifier continued (#92) * KZG Prover generate verifier index * Deserialize verifier index * Added remaining msgpack primitives * Fix uint deser * Add public_len field * Initialize alphas * Final fixes * Add constraint count for pows of alpha * Added combined evaluations step * Added fake witness * Fixed issues regarding fake witness * Added comments, removed printlns * Satisfy copy constraints * Revert fake witness development * Added test circuit kzg proof * Disable test circuit proof gen * Added vanishing poly * Continuing final comm step * Added perm scalars * Added PolishToken * Added new test circuit for the KZG prover * Added better comment to polishtoken * RPN progress * Finished preliminary rpn evaluation * Fixes * Test verifier index from new circuit * WIP fixes for deserialization * Final fixes * Deserialized part of the prover proof * Deserialize public evals * Deserialize rest of evals * Finish deserializing index and proof * Integrated verifier with deserializer * Added lagrange bases deserialization * Fixes * Added PairingURS and started deser function * Finished writing URS deserializer and forge script * Fix EncodedMap non-string keys * Remove duplicated function * Remove logs * Random URS and lagrange bases * Temporarily remove URS serialization * Small fixes * Add documentation --------- Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
pablodeymo
added a commit
that referenced
this pull request
Jan 2, 2024
* Added public input evals * Fixes * Absorb public evals * Added combined_evals and others * Added get alphas * Minor * Progress on ft eval * Added combined inner prod * Fixing comb inn prod * Fixed 3d array prob * Fix compile errors: * Add error * README * Deserialize VerifierIndex from KZG prover and fixes (#89) * Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove repeated lines Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove unused import Co-authored-by: Pablo Deymonnaz <[email protected]> * Change o1js submodule commit * Changed commit again * Ethereum verifier continued (#92) * KZG Prover generate verifier index * Deserialize verifier index * Added remaining msgpack primitives * Fix uint deser * Add public_len field * Initialize alphas * Final fixes * Add constraint count for pows of alpha * Added combined evaluations step * Added fake witness * Fixed issues regarding fake witness * Added comments, removed printlns * Satisfy copy constraints * Revert fake witness development * Added test circuit kzg proof * Disable test circuit proof gen * Added vanishing poly * Continuing final comm step * Added perm scalars * Added PolishToken * Added new test circuit for the KZG prover * Added better comment to polishtoken * RPN progress * Finished preliminary rpn evaluation * Fixes * Test verifier index from new circuit * WIP fixes for deserialization * Final fixes * Deserialized part of the prover proof * Deserialize public evals * Deserialize rest of evals * Finish deserializing index and proof * Integrated verifier with deserializer * Added lagrange bases deserialization * Fixes * Added PairingURS and started deser function * Finished writing URS deserializer and forge script * Fix EncodedMap non-string keys * Remove duplicated function * Remove logs * Random URS and lagrange bases * Temporarily remove URS serialization * Small fixes * Add documentation * Added linearization structures * Finished linearized poly commitment compute * Fix stash conflict * Fixes * Deserialize some verifier index commitments * Added prover proof commitment deserialization * Added urs deser warning * Continued with next step * Started writing a deserializer for the linearization * Added linearization serialization * Fix MDS variant * Added unit variant * Implemented linearization unit variants deser * Finished linearization deser * Fixes * Remove linearization print * Add TODO in empty Commitment fn Co-authored-by: Pablo Deymonnaz <[email protected]> --------- Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
pablodeymo
added a commit
that referenced
this pull request
Jan 4, 2024
…mart contract (#106) * Added public input evals * Fixes * Absorb public evals * Added combined_evals and others * Added get alphas * Minor * Progress on ft eval * Added combined inner prod * Fixing comb inn prod * Fixed 3d array prob * Fix compile errors: * Add error * README * Deserialize VerifierIndex from KZG prover and fixes (#89) * Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove repeated lines Co-authored-by: Pablo Deymonnaz <[email protected]> * Remove unused import Co-authored-by: Pablo Deymonnaz <[email protected]> * Change o1js submodule commit * Changed commit again * Ethereum verifier continued (#92) * KZG Prover generate verifier index * Deserialize verifier index * Added remaining msgpack primitives * Fix uint deser * Add public_len field * Initialize alphas * Final fixes * Add constraint count for pows of alpha * Added combined evaluations step * Added fake witness * Fixed issues regarding fake witness * Added comments, removed printlns * Satisfy copy constraints * Revert fake witness development * Added test circuit kzg proof * Disable test circuit proof gen * Added vanishing poly * Continuing final comm step * Added perm scalars * Added PolishToken * Added new test circuit for the KZG prover * Added better comment to polishtoken * RPN progress * Finished preliminary rpn evaluation * Fixes * Test verifier index from new circuit * WIP fixes for deserialization * Final fixes * Deserialized part of the prover proof * Deserialize public evals * Deserialize rest of evals * Finish deserializing index and proof * Integrated verifier with deserializer * Inicial code and comments for final_verify function * Added lagrange bases deserialization * Fixes * Added PairingURS and started deser function * Finished writing URS deserializer and forge script * Fix EncodedMap non-string keys * Remove duplicated function * Remove logs * Random URS and lagrange bases * Temporarily remove URS serialization * Small fixes * minor spaces * Cargo lock updated * eval_polynomial function in solidity * Evaluation struct * first attemp of combineCommitments * Evaluation corrected * wip * function deserializeScalar removed * correction in combineCommitments * changing format * format deserialize * format Commitment.sol * reformat code to avoid merge conflicts * changes in Fields reverted * Fields.sol modified to avoid conflics * eval_polynomial changed to view * Small fixes in comments * shifted attribute added in PolyComm * combineCommitments * comment removed * Reordering code in order to merge it * fn name change * Remove unnecessary code comments --------- Co-authored-by: Estéfano Bargas <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.