Integrated verifier with deserializer #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add foreign group usage * KZG Prover generate verifier index * [WIP] Debug ForeignGroup assertEquals * Replaced job's OS. (#88) * Use foreign EC addition gate * Deserialize verifier index * Added remaining msgpack primitives * Go back to min Kimchi verifier * Use foreign EC op gates * Fix uint deser * Remove unused imports * Update o1js * Add public_len field * Add ForeignFieldMul gate case * Initialize alphas * Kimchi o1js prover: combine_point_evaluations function deleted (#91) Co-authored-by: Pablo Deymonnaz <[email protected]> * Final fixes --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
Co-authored-by: Pablo Deymonnaz <[email protected]>
Co-authored-by: Pablo Deymonnaz <[email protected]>
* KZG Prover generate verifier index * Deserialize verifier index * Added remaining msgpack primitives * Fix uint deser * Add public_len field * Initialize alphas * Final fixes * Add constraint count for pows of alpha * Added combined evaluations step * Added fake witness * Fixed issues regarding fake witness * Added comments, removed printlns * Satisfy copy constraints * Revert fake witness development * Added test circuit kzg proof * Disable test circuit proof gen * Added vanishing poly * Continuing final comm step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea of this PR was to add serialization for the full URS and completely integrate the verifier with the deserializer. Nonetheless this was not possible because Foundry's
readBinaryFile(path)function (used in a forge script for locally deploying and running the contract) doesn't retrieve the original bytes of the file but the RLP encoded version of them, which can't be decoded in Solidity for some reason usingabi.decode(), so we can't read the serialized URS from a file and because of its size it's impossible to hard-code it. The same problem exists now for the verifier index, but this can be, and was, hardcoded.So the PR adds somewhat unused deserialization logic, code for generating a fake URS in Solidity, a forge script for running verification in Anvil, small fixes in the verifier contract and the ability for the prover to serialize the full SRS.