-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: keep min and max referenced offsets during run #1080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results for unmodified programs 🚀
|
Oppen
force-pushed
the
perf/running_perm_range_check_limits
branch
3 times, most recently
from
May 3, 2023 19:40
eba668e
to
a37116b
Compare
This reverts commit eae76bb92a33de5dd5f488a08efe18b91846b2dd.
Oppen
force-pushed
the
perf/running_perm_range_check_limits
branch
from
May 11, 2023 21:10
a37116b
to
42c2455
Compare
Oppen
requested review from
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
June 10, 2023 02:59
Codecov Report
@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
+ Coverage 97.60% 97.61% +0.01%
==========================================
Files 89 88 -1
Lines 36205 36112 -93
==========================================
- Hits 35337 35251 -86
+ Misses 868 861 -7
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MegaRedHand
approved these changes
Jun 12, 2023
pefontana
approved these changes
Jun 13, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * Fix trace * WIP * Revert "WIP" This reverts commit eae76bb92a33de5dd5f488a08efe18b91846b2dd. * test: remove no longer relevant tests * Fix missing reassignment of cache * Cleanup and correctness * chore: changelog * refactor: don't return Result --------- Co-authored-by: Pedro Fontana <[email protected]> Co-authored-by: Tomá <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Description of the pull request changes and motivation.
Checklist