Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/#107 Authentication tokens for APIs pt. 2 #156

Merged
merged 8 commits into from
Oct 15, 2022

Conversation

tuz666
Copy link
Collaborator

@tuz666 tuz666 commented Oct 11, 2022

We separated the Authentication tokens for APIs task into two PRs in order to provide time for our frontend and mobile app for a smoother uplift:

  1. During the first PR (Dev/#107 Authentication tokens for APIs #153) we introduced the auth_token handling and protected our POST and DELETE APIs.
  2. Now we gonna make our GET APIs protected too.

etc:

  • I did a little refactoring with the duplicated add/edit_item/show functions, now it doesn't mess up the whole changes view.
  • Sometimes the CI test failed on the item upload, because it reached the maximum 10 sec response time, I increased this maximum value to 12.5 sec
  • Updated the annotations on Arcsi's view functions (if someone register he/she/they can have a look on it), and fixed the episode listen/download api?

@tuz666 tuz666 temporarily deployed to dev October 11, 2022 17:01 Inactive
@tuz666 tuz666 temporarily deployed to dev October 11, 2022 17:03 Inactive
@tuz666 tuz666 temporarily deployed to dev October 11, 2022 18:03 Inactive
@tuz666 tuz666 temporarily deployed to dev October 11, 2022 18:11 Inactive
@tuz666 tuz666 requested review from pvj, gammaw and molnar-a October 11, 2022 18:11
@tuz666 tuz666 temporarily deployed to dev October 11, 2022 20:23 Inactive
arcsi/api/item.py Outdated Show resolved Hide resolved
@tuz666 tuz666 temporarily deployed to dev October 15, 2022 09:33 Inactive
Copy link
Member

@gammaw gammaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up! And clarification of the exact meaning of the different auth annotations. Also, thanks for the small player adjustment.

@tuz666 tuz666 merged commit 7d2796a into master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants