-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/#107 Authentication tokens for APIs #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented your draft Solid first steps and good test db and test key set-up. I hope to help when you continue
…nm/lahmacun_arcsi into dev/#107-praetorian_authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tuz666 thanks for the bold changes! Looks just like we discussed, I just had a couple of questions for clarification before I approve. Can you look into them?
removing auth_token_required annotation from GET requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments and the changes, especially, the Swagger updates, which was additional work! Let's start step 1 then (arcsi release w/ only POST APIs being protected)!
Thanks for the review @gammaw , I will push the green button then :) |
A long awaited missing piece of our Arcsi seems to be finished soon. (#107 , #108 )
Our first idea to implement authentication token handling was to start using flask-praetorian, which is a light-weight, API-oriented security package. (#126 ) As far as I remember we also thought that flask-security - what we are using currently - is a dead project and doesn't supported anymore.
I made some attempts to import flask-praetorian into our code parallelly with flask-security. During these process and research it turned out that flask-security also contains the features which we wanted to bring in with flask-praetorian. Also I found a package named flask-security-too, which is an independent well-maintained fork with high code coverage and nice documentation. After these news I stopped the experiments with flask-praetorian and started to work with flask-security.