Make sure the ALM API returns usage stats for counter and pmc #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't want to create test fixtures, as this project is probably moving to factories soon. I tried to change the existing code as little as possible, in the future we might consider refactoring some of the methods for easier unit testing. |
|
Looking good Martin, thanks! Merging. |
jure
added a commit
that referenced
this pull request
Sep 5, 2014
Make sure the ALM API returns usage stats for counter and pmc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests gracefully handles situations where the ALM API returns no event data for
counterorpmcand fixes #13. Added unit tests to confirm that thegenerate_data_for_usage_chartmethod works as expected. Also made a small tweak to the Javascript handling the missing data.