Visualizations 500 in production

[jure]

Just stumbled on this during development. For example: http://almreports.plos.org/reports/metrics/13743

2014-09-01 22:34:09.185 [FATAL] NoMethodError (undefined method `inject' for nil:NilClass):
  lib/chart_data.rb:186:in `generate_data_for_usage_chart'
  app/controllers/reports_controller.rb:123:in `visualizations'
  app/controllers/application_controller.rb:114:in `save_session_dois' (pid:3564)

Will take a look tomorrow.

[mfenner]

From looking at production.log I know that there are occasional errors like this. One of the nicest Ruby books I have read recently is https://pragprog.com/book/ager/exceptional-ruby by Avdi Grimm. He goes into great detail how to handle nils, wrong classes, etc., using a very interesting, proactive approach.

[jure]

Still haven't looked into this one. @mfenner: Is this same/related to #24?

[mfenner]

This is not directly related, but is the same idea: properly handle missing data in the response from the ALM API. Let me know if you want me to do anything (as I have a pretty good idea what comes from the ALM API, and what might have changed).

[mfenner]

With the fixes in the pull request the report in your example no longer produces an error, but I'm not sure I have covered all possible scenarios.

[jure]

🎉