Fix broken visualizations of single articles #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, I guess this is a case in point for the specs/mocks to work with live(r) data. |
jure
added a commit
that referenced
this pull request
Sep 5, 2014
Fix broken visualizations of single articles
|
I was thinking the same :). The alternative approach that I have taken so far is having good error reporting from the live application. And as you know I am working on that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the ALM API has changed the format of how we return historical data in ALM 3.0, the visualization for single articles is broken. This only affects the citations chart.
The temporary workaround is to properly handle nil. We can later refactor to use the new monthly history data, but first have to switch to the v5 API for that.
Unit tests confirm the expected behaviour.