Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite for labscript #41

Open
philipstarkey opened this issue Jun 28, 2017 · 2 comments
Open

Test suite for labscript #41

philipstarkey opened this issue Jun 28, 2017 · 2 comments
Labels
enhancement New feature or request major

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


Changes to labscript that contain unexpected bugs, risk breaking people's experiments. Worse, a mistake could adversely affect the ability to obtain scientific results, or even invalidate publications. Corner cases are often hard to catch during testing, and may persist for years. To combat this, we should implement a test suite.

I suggest that we expose the runviewer Shot class in an API and use the traces (that are reverse engineered from the hardware instructions stored in the hdf5 file) to verify that outputs still maintain the same behaviour after labscript changes.

We should also:

  • have something in the test suite that detects ramps, and warns (but not fails) the test if the clock ticks (and thus the ramp evaluation points) have changed slightly.
  • Determines if part of the trace is just shifted in time (so that we can determine if the shift is expected - e.g. because we increased the trigger time when fixing a bug)
  • Create a comprehensive test shot that uses all standard hardware, along with expected traces (generated by hand, so that the test does not fail (or worse, pass) due to a mistake in the runviewer API) to be used before merging pull requests.
  • use mercurial to pull the expected behaviour of past versions for comparison with the expected behaviour of the current version
@philipstarkey
Copy link
Member Author

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


  • Edited issue description

@philipstarkey philipstarkey added major enhancement New feature or request labels Apr 5, 2020
Loki27182 pushed a commit to Loki27182/labscript that referenced this issue Oct 9, 2023
@dihm
Copy link
Contributor

dihm commented Jan 28, 2024

Now that #102 is in the works and there is some more serious discussion of breaking changes (#104, #105), this effort should be revisited in earnest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major
Projects
None yet
Development

No branches or pull requests

2 participants