Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pylab star import in labscript.labscript #104

Open
dihm opened this issue Jan 28, 2024 · 0 comments
Open

Remove pylab star import in labscript.labscript #104

dihm opened this issue Jan 28, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@dihm
Copy link
Contributor

dihm commented Jan 28, 2024

As discussed in #102, it would be good to remove any and all star imports, especially pylab which is largely deprecated and brings in a ton of junk to the labscript namespace.

A hurdle to this is that users are likely accidentally relying on some of these imports in their scripts. If we wanted to avoid a breaking change, we could just go through and manually import the useful stuff that pylab brings (even if we aren't specifically using it within labscript). Though it is probably better to just pull the bandaid and even update the docs to discourage the from labscript import * idiom.

@dihm dihm added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant