Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): remove unused env-tester files #1956

Merged
merged 6 commits into from
Apr 8, 2024
Merged

chore(tests): remove unused env-tester files #1956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d693e6
tests : remove unused env-tester files
mirageoasis Mar 13, 2024
4cb8e3a
docs : added docs to explain changes
mirageoasis Mar 13, 2024
d9c59dd
docs : added docs to explain changes
mirageoasis Mar 13, 2024
5b9c53a
docs : added docs to explain changes
mirageoasis Mar 13, 2024
d2209d8
doc: Simplify the news fragment
achimnol Apr 8, 2024
109e76c
Merge branch 'main' into tests/remove-tester-script
achimnol Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ jobs:
shell: 'script -q -e -c "bash {0}"'
run: |
./scripts/install-dev.sh
source env-tester-admin.sh
./backend.ai test run-cli admin
source env-tester-user.sh
./backend.ai test run-cli user
- name: Upload pants log
uses: actions/upload-artifact@v3
Expand Down
1 change: 1 addition & 0 deletions changes/1956.deprecation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove no longer used `env-tester-{admin,user,user2}.sh` scripts and all references
11 changes: 0 additions & 11 deletions scripts/install-dev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,11 +941,6 @@ configure_backendai() {
show_note "The currently embedded webui version: $webui_version"
fi

# configure tester
echo "export BACKENDAI_TEST_CLIENT_ENV=${PWD}/env-local-admin-api.sh" > ./env-tester-admin.sh
echo "export BACKENDAI_TEST_CLIENT_ENV=${PWD}/env-local-user-api.sh" > ./env-tester-user.sh
echo "export BACKENDAI_TEST_CLIENT_ENV=${PWD}/env-local-user2-api.sh" > ./env-tester-user2.sh

if [ "${CODESPACES}" = "true" ]; then
$docker_sudo docker stop $($docker_sudo docker ps -q)
$docker_sudo docker compose -f "docker-compose.halfstack.current.yml" down
Expand Down Expand Up @@ -1085,12 +1080,6 @@ configure_backendai() {
echo "echo 'Password: $(cat fixtures/manager/example-keypairs.json | jq -r '.users[] | select(.username=="user") | .password')'" >> "${CLIENT_USER_CONF_FOR_SESSION}"
chmod +x "${CLIENT_USER_CONF_FOR_SESSION}"

# TODO: Update tester env script
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_VENV=/home/user/.pyenv/versions/venv-dev-client@export BACKENDAI_TEST_CLIENT_VENV=${VENV_PATH}@" ./env-tester-admin.sh
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_ENV=/home/user/bai-dev/client-py/my-backend-session.sh@export BACKENDAI_TEST_CLIENT_ENV=${INSTALL_PATH}/client-py/${CLIENT_ADMIN_CONF_FOR_API}@" ./env-tester-admin.sh
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_VENV=/home/user/.pyenv/versions/venv-dev-client@export BACKENDAI_TEST_CLIENT_VENV=${VENV_PATH}@" ./env-tester-user.sh
## sed_inplace "s@export BACKENDAI_TEST_CLIENT_ENV=/home/user/bai-dev/client-py/my-backend-session.sh@export BACKENDAI_TEST_CLIENT_ENV=${INSTALL_PATH}/client-py/${CLIENT_USER_CONF_FOR_API}@" ./env-tester-user.sh

show_info "Dumping the installed etcd configuration to ./dev.etcd.installed.json as a backup."
./backend.ai mgr etcd get --prefix '' > ./dev.etcd.installed.json

Expand Down
Loading