Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): remove unused env-tester files #1956

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

mirageoasis
Copy link
Collaborator

@mirageoasis mirageoasis commented Mar 13, 2024

while reviewing cli-test improvement I worked on
I found out that env-tester-admin env-tester-user env-tester-user2 file is no longer needed

#1778

hence, I found out why user-defined option was not working on pytest

Link
Link

CleanShot 2024-03-13 at 21 13 41

it says we have to fix pytest.toml to add options in pytest. since it search only root dir in pytest

@mirageoasis mirageoasis requested a review from Yaminyam March 13, 2024 07:58
@github-actions github-actions bot added the size:S 10~30 LoC label Mar 13, 2024
@mirageoasis mirageoasis changed the title tests : remove unused env-tester files chore : remove unused env-tester files Mar 13, 2024
@mirageoasis mirageoasis changed the title chore : remove unused env-tester files chore: remove unused env-tester files Mar 13, 2024
@mirageoasis mirageoasis changed the title chore: remove unused env-tester files chore(tests): remove unused env-tester files Mar 13, 2024
@mirageoasis mirageoasis requested a review from achimnol March 13, 2024 08:16
@achimnol achimnol added this to the 23.09 milestone Apr 8, 2024
@achimnol achimnol enabled auto-merge April 8, 2024 07:44
@achimnol achimnol added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 355af08 Apr 8, 2024
26 checks passed
@achimnol achimnol deleted the tests/remove-tester-script branch April 8, 2024 07:50
achimnol added a commit that referenced this pull request Apr 8, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Co-authored-by: Joongi Kim <[email protected]>
achimnol added a commit that referenced this pull request Apr 8, 2024
Backported-from: main (24.09)
Backported-to: 23.09
Co-authored-by: Joongi Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants