Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated data source #7

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

toabi
Copy link
Contributor

@toabi toabi commented Jul 7, 2020

See https://www.terraform.io/docs/providers/helm/d/repository.html

I think this should have the same behavior.

@toabi
Copy link
Contributor Author

toabi commented Jul 7, 2020

Ah. Didn't see the big updates in the main repo. Sorry, will update PR.

@martinhaus martinhaus self-requested a review July 7, 2020 07:41
@toabi toabi force-pushed the fix/deprecated_resource branch from 910b8ea to 43c12b4 Compare July 7, 2020 07:49
@martinhaus
Copy link
Member

@toabi Thanks for this! The checks failed because the docs were not updated. Can you run terraform_docs to update the readme as well? If not I can make the change so we can merge this.

@martinhaus
Copy link
Member

LGTM, thanks again!

@martinhaus martinhaus merged commit 014f374 into lablabs:master Jul 7, 2020
@toabi toabi deleted the fix/deprecated_resource branch July 15, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants