Skip to content

Commit

Permalink
Merge pull request #7 from toabi/fix/deprecated_resource
Browse files Browse the repository at this point in the history
fix: remove deprecated data source
  • Loading branch information
martinhaus authored Jul 7, 2020
2 parents 2174198 + ec1270b commit 014f374
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 12 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ A terraform module to deploy an ExternalDNS on Amazon EKS cluster.
| helm\_chart\_name | n/a | `string` | `"external-dns"` | no |
| helm\_chart\_version | n/a | `string` | `"2.11.0"` | no |
| helm\_release\_name | n/a | `string` | `"external-dns"` | no |
| helm\_repo\_name | n/a | `string` | `"stable"` | no |
| helm\_repo\_url | n/a | `string` | `"https://kubernetes-charts.storage.googleapis.com"` | no |
| k8s\_namespace | The k8s namespace in which the external-dns service account has been created | `string` | `"kube-system"` | no |
| k8s\_service\_account\_name | The k8s external-dns service account name | `string` | `"external-dns"` | no |
Expand Down
8 changes: 1 addition & 7 deletions main.tf
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@
data "helm_repository" "default" {
depends_on = [var.mod_dependency]
name = var.helm_repo_name
url = var.helm_repo_url
}

data "aws_region" "current" {}

resource "helm_release" "external_dns" {
depends_on = [var.mod_dependency]
count = var.enabled ? 1 : 0
name = var.helm_release_name
repository = data.helm_repository.default.metadata[0].name
repository = var.helm_repo_url
chart = var.helm_chart_name
namespace = var.k8s_namespace
version = var.helm_chart_version
Expand Down
4 changes: 0 additions & 4 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ variable "helm_release_name" {
default = "external-dns"
}

variable "helm_repo_name" {
default = "stable"
}

variable "helm_repo_url" {
default = "https://kubernetes-charts.storage.googleapis.com"
}
Expand Down

0 comments on commit 014f374

Please sign in to comment.